Repository navigation
build: force BouncyCastle 1.86 on the Gradle plugin classpath - #343
Merged
Merged
Conversation
The generated Maven Central upload plugin pulls in BouncyCastle 1.77. Override it in settings-extra.gradle, which Speakeasy never regenerates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified with the BouncyCastle dependency-resolution update.
No open issues 🎉
What changed in this PR
This pull request updates the Gradle plugin classpath to use BouncyCastle 1.86 instead of the outdated transitive 1.77 version from the Sonatype upload plugin.
Changes:
- Adds a non-generated Gradle settings hook for dependency resolution.
- Forces all
org.bouncycastlebuildscript dependencies to version 1.86. - Preserves the generated publishing configuration and existing SDK dependency declarations.
| File | Description |
|---|---|
settings-extra.gradle |
Configures the root buildscript resolution strategy to use BouncyCastle 1.86 for Gradle plugin dependencies. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
settings-extra.gradlechanges the publish job's build classpathForces BouncyCastle 1.86 for the build's plugins. Speakeasy's generated
sonatype-central-upload1.0.3 pulls in 1.77, which GitHub flags (alerts #19–#30, dismissed as build-time only).Speakeasy suggested this (#gr4vy-speakeasy, ticket 12970):
settings.gradleappliessettings-extra.gradle, and the generator never writes it../gradlew buildEnvironmentnow showsbcprov-jdk18on:1.77 -> 1.86andbcpg-jdk18on:1.77 -> 1.86;sonatypeCentralUploadis unchanged. The published SDK already ships 1.86.🤖 Generated with Claude Code